Skip to content

gpuid-multiple-ids.php: Added option to use multiple fields for count #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025

Conversation

codepuncher
Copy link
Contributor

Context

https://gravitywiz.com/gravity-forms-build-raffle-or-lottery/

Summary

This is to extend the raffle/lottery ticket example on here: https://gravitywiz.com/gravity-forms-build-raffle-or-lottery/

While the guide supports "packages" of pre-defined counts for choice selections, it does not allow user-defined counts for multiple ticket types.

This PR allows you to specify multiple field IDs that will all be counted and totalled to the final count allowing you to sell multiple ticket types with as many as a user would like to purchase.

Copy link

coderabbitai bot commented Aug 7, 2025

Walkthrough

Added an elseif branch to GPUID_Multiple_IDs::get_count to accept a count argument with a field_ids array: it reads each field value from the entry, converts to integers, sums their absolute values, and returns the total. A commented example configuration was also added.

Changes

Cohort / File(s) Change Summary
Enhanced count logic for multiple field IDs
gp-unique-id/gpuid-multiple-ids.php
Inserted an elseif branch in GPUID_Multiple_IDs::get_count to handle count when it includes a field_ids array; retrieves values for each field from the entry, casts to int, sums absolute values, and returns the sum. Added a commented example configuration.

Sequence Diagram(s)

sequenceDiagram
    actor Caller
    participant GPUID as GPUID_Multiple_IDs
    participant Entry as EntryStore

    Caller->>GPUID: get_count(entry, countArg)
    alt countArg contains field_ids array
        loop for each field_id
            GPUID->>Entry: get value for field_id
            Entry-->>GPUID: valueN
        end
        GPUID->>GPUID: cast to int, abs, sum values
        GPUID-->>Caller: return totalSum
    else other count formats
        GPUID->>GPUID: existing branches (single field, static, etc.)
        GPUID-->>Caller: return result
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • veryspry
  • saifsultanc

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 04c2030 and 304edc3.

📒 Files selected for processing (1)
  • gp-unique-id/gpuid-multiple-ids.php (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • gp-unique-id/gpuid-multiple-ids.php
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codepuncher codepuncher force-pushed the patch-1 branch 5 times, most recently from e4900ba to 04c2030 Compare August 13, 2025 09:02
…count

This is to extend the raffle/lottery ticket example on here: https://gravitywiz.com/gravity-forms-build-raffle-or-lottery/

While the guide supports "packages" of pre-defined counts for choice selections, it does not allow user-defined counts for multiple ticket types.

This PR allows you to specify multiple field IDs that will all be counted and totalled to the final count allowing you to sell multiple ticket types with as many as a user would like to purchase.
Copy link
Contributor

@veryspry veryspry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission!

@veryspry veryspry merged commit 1c23cff into gravitywiz:master Aug 13, 2025
1 of 4 checks passed
@codepuncher codepuncher deleted the patch-1 branch August 13, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants